Skip to content

Add optionsPlace to placeBlock#3331

Closed
iiroak wants to merge 9 commits intoPrismarineJS:masterfrom
Minecraft-IRK:master
Closed

Add optionsPlace to placeBlock#3331
iiroak wants to merge 9 commits intoPrismarineJS:masterfrom
Minecraft-IRK:master

Conversation

@iiroak
Copy link
Copy Markdown

@iiroak iiroak commented Mar 18, 2024

Using this function, you need to be able to control the wait time for block placement. This could make the timeout and swingarm changeable.

@rom1504
Copy link
Copy Markdown
Member

rom1504 commented Apr 19, 2024

/fixlint

@rom1504bot
Copy link
Copy Markdown
Collaborator

I ran npm run fix which fixed the lint, but I couldn't push the changes to this branch as the PR author didn't grant write permissions to the maintainers. The PR author must manually run npm run fix and push the changes.

@rom1504
Copy link
Copy Markdown
Member

rom1504 commented Apr 19, 2024

can you use this in an example?

@iiroak
Copy link
Copy Markdown
Author

iiroak commented Apr 23, 2024

Hello, sorry for the delay, I made this change because I am making a bot to print MapArts, the problem was that I was using awaits, but the waiting time was too long, I needed a faster confirmation, because if I didn't place it in that time indicated, it was not necessary to wait for the default, so I pushed this, in a while I will make a fix and change what they told me

@rom1504
Copy link
Copy Markdown
Member

rom1504 commented Mar 18, 2025

Problems left here

  • fails tests
  • no example
  • not super clear why we need this

It's been a while so maybe we'll just close.

Let me know if you still need it

@Minecraft-IRK Minecraft-IRK closed this by deleting the head repository Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting for user input

Development

Successfully merging this pull request may close these issues.

4 participants